[PATCH] D15677: Cost for Gather and Scatter operations.

[Elena Demikhovsky via llvm-commits]

delena marked 6 inline comments as done.

================
Comment at: ../lib/Target/X86/X86TargetTransformInfo.cpp:572
@@ -571,2 +571,3 @@
     { ISD::SIGN_EXTEND, MVT::v8i64,  MVT::v8i16,  1 },
+    { ISD::SIGN_EXTEND, MVT::v8i64,  MVT::v16i32, 3 },
 
----------------
Ayal wrote:
> this is independent of the rest of the patch, right?
removed, it does not help with the current cost model algirithm

================
Comment at: ../lib/Target/X86/X86TargetTransformInfo.cpp:1353-1354
@@ +1352,4 @@
+
+  // The gather / scatter cost is given by Intel architects. It is a rough
+  // number since we are looking at one intruction in a time.
+  const int GSOverhead = 2;
----------------
Ayal wrote:
> in[s]truction at a time
I don't know ho to add spell checker plug-in to kdevelop

================
Comment at: ../lib/Target/X86/X86TargetTransformInfo.cpp:1425
@@ +1424,3 @@
+  // the mask vector will add more instructions. Right now we decide
+  // to scalarize vector-4 for KNL.
+  if (VF == 2 || (VF == 4 && !ST->hasVLX()))
----------------
Ayal wrote:
> Mark as TODO?
no


Repository:
  rL LLVM

http://reviews.llvm.org/D15677