[PATCH] D15325: [WinEH] Update CoreCLR EH state numbering

David Majnemer via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 25 02:36:18 PST 2015


majnemer added inline comments.

================
Comment at: lib/CodeGen/WinEHPrepare.cpp:641-642
@@ -521,3 +640,4 @@
 
+  // Step three: transfer information from pads to invokes.
   calculateStateNumbersForInvokes(Fn, FuncInfo);
 }
----------------
Is `calculateStateNumbersForInvokes` correct for your personality?  I'm surprised it went through untouched.  Specifically, the bit where we use `getCleanupRetUnwindDest` seems a little sketchy...


http://reviews.llvm.org/D15325





More information about the llvm-commits mailing list