[llvm] r256413 - [CodeGen] Use generic printAsOperand machinery instead of hand rolling it

David Majnemer via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 25 01:37:26 PST 2015


Author: majnemer
Date: Fri Dec 25 03:37:26 2015
New Revision: 256413

URL: http://llvm.org/viewvc/llvm-project?rev=256413&view=rev
Log:
[CodeGen] Use generic printAsOperand machinery instead of hand rolling it

We already know how to properly print out basic blocks in
printAsOperand, we should not roll it ourselves in
AsmPrinter::EmitBasicBlockStart.  No functionality change is intended.

Modified:
    llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp

Modified: llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp?rev=256413&r1=256412&r2=256413&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp (original)
+++ llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp Fri Dec 25 03:37:26 2015
@@ -2503,9 +2503,13 @@ void AsmPrinter::EmitBasicBlockStart(con
 
   // Print some verbose block comments.
   if (isVerbose()) {
-    if (const BasicBlock *BB = MBB.getBasicBlock())
-      if (BB->hasName())
-        OutStreamer->AddComment("%" + BB->getName());
+    if (const BasicBlock *BB = MBB.getBasicBlock()) {
+      if (BB->hasName()) {
+        BB->printAsOperand(OutStreamer->GetCommentOS(),
+                           /*PrintType=*/false, BB->getModule());
+        OutStreamer->GetCommentOS() << '\n';
+      }
+    }
     emitBasicBlockLoopComments(MBB, LI, *this);
   }
 




More information about the llvm-commits mailing list