[PATCH] D15495: Macro Support in Dwarf emission

Amjad Aboud via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 24 03:37:55 PST 2015

aaboud added a comment.

Thanks Adrian for the comments.
I tried to answer most of them and uploaded a new version with the changes.
Please see my response below.

Comment at: lib/CodeGen/AsmPrinter/DwarfDebug.cpp:1919
@@ +1918,3 @@
+  Size += getULEB128Size(F.getLine());
+  DIFile *File = F.getFile();
+  unsigned FID =
I could not find an elegant and less messy way to do share code between these functions.
Also, in DIE.cpp you can see that there is a similar implementation for "EmitValue()" and "SizeOf()" where common code is not shared!

I tried at least to encapsulate the handling of the macro node array, as it is being repeated three times in the code.

Please, let me know if you have a better idea on how to share the common code above.


More information about the llvm-commits mailing list