[llvm] r256353 - WebAssembly: remove 'external' from test

JF Bastien via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 23 15:56:13 PST 2015

Author: jfb
Date: Wed Dec 23 17:56:13 2015
New Revision: 256353

URL: http://llvm.org/viewvc/llvm-project?rev=256353&view=rev
WebAssembly: remove 'external' from test

Summary: Linker testing was sad at seeing an unresolved external symbol. For now don't do that: it's valid but we're not playing with multi-file linking yet, and the LLVM tests are used as hacky sanity tests for single-file linking (the GCC torture tests are much better for this purpose). Another solution would be to use '.extern' to make the intent explicit (don't simple-file link this, there's an unresolved symbol), some assemblers use '.extern' while others ignore it, so we wouldn't really be inventing anything new.

Reviewers: sunfish, kripken

Subscribers: jfb, llvm-commits, dschuff

Differential Revision: http://reviews.llvm.org/D15753


Modified: llvm/trunk/test/CodeGen/WebAssembly/offset-folding.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/WebAssembly/offset-folding.ll?rev=256353&r1=256352&r2=256353&view=diff
--- llvm/trunk/test/CodeGen/WebAssembly/offset-folding.ll (original)
+++ llvm/trunk/test/CodeGen/WebAssembly/offset-folding.ll Wed Dec 23 17:56:13 2015
@@ -5,7 +5,10 @@
 target datalayout = "e-p:32:32-i64:64-n32:64-S128"
 target triple = "wasm32-unknown-unknown"
- at x = external global [0 x i32]
+; FIXME: make this 'external' and make sure it still works. WebAssembly
+;        currently only supports linking single files, so 'external' makes
+;        little sense.
+ at x = global [0 x i32] zeroinitializer
 @y = global [50 x i32] zeroinitializer
 ; Test basic constant offsets of both defined and external symbols.

More information about the llvm-commits mailing list