[PATCH] D15753: WebAssembly: remove 'external' from test

JF Bastien via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 23 15:58:21 PST 2015

jfb updated this revision to Diff 43563.
jfb added a comment.

- Add fixme.



Index: test/CodeGen/WebAssembly/offset-folding.ll
--- test/CodeGen/WebAssembly/offset-folding.ll
+++ test/CodeGen/WebAssembly/offset-folding.ll
@@ -5,7 +5,10 @@
 target datalayout = "e-p:32:32-i64:64-n32:64-S128"
 target triple = "wasm32-unknown-unknown"
- at x = external global [0 x i32]
+; FIXME: make this 'external' and make sure it still works. WebAssembly
+;        currently only supports linking single files, so 'external' makes
+;        little sense.
+ at x = global [0 x i32] zeroinitializer
 @y = global [50 x i32] zeroinitializer
 ; Test basic constant offsets of both defined and external symbols.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D15753.43563.patch
Type: text/x-patch
Size: 680 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151223/5d80ec76/attachment-0001.bin>

More information about the llvm-commits mailing list