[PATCH] D15730: [MachineLICM] Fix handling of memoperands
Andrew Trick via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 23 11:12:54 PST 2015
> On Dec 23, 2015, at 11:03 AM, Philip Reames <listmail at philipreames.com> wrote:
> reames added a comment.
> In http://reviews.llvm.org/D15730#316291, @atrick wrote:
>> AArch64 uses a concatenateMemOperands utility.
> Looking around, I see three copes of this routine (2 in tree, 1 under review). I think it makes sense to common this functionality. Would a static function on MachineInstr be a reasonable place for this? Or is there a better location for this type of utility function.
Sure, it should be a utility. I have no opinion on the specifics. Copying Tim, the AArch64 owner.
More information about the llvm-commits