[PATCH] D12345: [Reassociate]: Add intermediate subtract instructions created while negating to be redone later for more reassociate opportunities

Aditya Nandakumar via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 23 11:09:19 PST 2015

aditya_nandakumar marked 7 inline comments as done.

Comment at: lib/Transforms/Scalar/Reassociate.cpp:613
@@ -610,3 +612,3 @@
         // No uses outside the expression, try morphing it.
-      } else if (It != Leaves.end()) {
+      } else {
         // Already in the leaf map.
mcrosier wrote:
> I assume this condition was removed because it will always be true, correct?  If so, please commit this in isolation.
Yes - I'll remove it and commit it separately


More information about the llvm-commits mailing list