[PATCH] D15753: WebAssembly: remove 'external' from test

JF Bastien via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 23 11:01:46 PST 2015

jfb created this revision.
jfb added reviewers: sunfish, kripken.
jfb added a subscriber: llvm-commits.
Herald added subscribers: dschuff, jfb.

Linker testing was sad at seeing an unresolved external symbol. For now don't do that: it's valid but we're not playing with multi-file linking yet, and the LLVM tests are used as hacky sanity tests for single-file linking (the GCC torture tests are much better for this purpose). Another solution would be to use '.extern' to make the intent explicit (don't simple-file link this, there's an unresolved symbol), some assemblers use '.extern' while others ignore it, so we wouldn't really be inventing anything new.



Index: test/CodeGen/WebAssembly/offset-folding.ll
--- test/CodeGen/WebAssembly/offset-folding.ll
+++ test/CodeGen/WebAssembly/offset-folding.ll
@@ -5,7 +5,7 @@
 target datalayout = "e-p:32:32-i64:64-n32:64-S128"
 target triple = "wasm32-unknown-unknown"
- at x = external global [0 x i32]
+ at x = global [0 x i32] zeroinitializer
 @y = global [50 x i32] zeroinitializer
 ; Test basic constant offsets of both defined and external symbols.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D15753.43549.patch
Type: text/x-patch
Size: 506 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151223/94816ee0/attachment.bin>

More information about the llvm-commits mailing list