[llvm] r256344 - Fix SCEV r256338.

JF Bastien via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 23 10:35:00 PST 2015


I was building locally with GCC 4.8.4:

/s/llvm/llvm/lib/Analysis/ScalarEvolution.cpp:9456:27: error: use of
‘L’ before deduction of ‘auto’
   for (auto *L : reverse(*L))
                           ^


On Wed, Dec 23, 2015 at 10:32 AM, Sanjoy Das <sanjoy at playingwithpointers.com
> wrote:

>
>
> JF Bastien via llvm-commits wrote:
>
>> Author: jfb
>> Date: Wed Dec 23 12:18:53 2015
>> New Revision: 256344
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=256344&view=rev
>> Log:
>> Fix SCEV r256338.
>>
>
> Thanks for the fix.  However, it looks like
>
>   for (auto *L : reverse(*L))
>     getLoopBackedgeTakenCounts(L, Map, SE); // recurse.
>
>
> compiles fine with clang 3.7.0 on OSX.  Any idea why the clang
> buildbots are different?
>
> -- Sanjoy
>
>
>
>> Modified:
>>      llvm/trunk/lib/Analysis/ScalarEvolution.cpp
>>
>> Modified: llvm/trunk/lib/Analysis/ScalarEvolution.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/ScalarEvolution.cpp?rev=256344&r1=256343&r2=256344&view=diff
>>
>> ==============================================================================
>> --- llvm/trunk/lib/Analysis/ScalarEvolution.cpp (original)
>> +++ llvm/trunk/lib/Analysis/ScalarEvolution.cpp Wed Dec 23 12:18:53 2015
>> @@ -9453,8 +9453,8 @@ getLoopBackedgeTakenCounts(Loop *L, Veri
>>       replaceSubString(OS.str(), "<nuw>", "");
>>     }
>>
>> -  for (auto *L : reverse(*L))
>> -    getLoopBackedgeTakenCounts(L, Map, SE); // recurse.
>> +  for (auto *R : reverse(*L))
>> +    getLoopBackedgeTakenCounts(R, Map, SE); // recurse.
>>   }
>>
>>   void ScalarEvolution::verify() const {
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151223/7301617f/attachment.html>


More information about the llvm-commits mailing list