[PATCH] D15272: [Verifier] Verifier that a GlobalValue is only used in this Module
Keno Fischer via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 23 10:18:49 PST 2015
Somewhere we have to have the logic as to which users we can handle (those
which are embedded in a module). We can have that in the callback with a
boolean flag as to whether we could handle it, or we could have that logic
in the foreach function. The latter seemed cleaner to me, but as I said, no
strong opinions here.
On Wed, Dec 23, 2015 at 7:12 PM, Rafael Espíndola <
rafael.espindola at gmail.com> wrote:
> > > How about having a single callback that takes a Value and do the cast
> in the callback?
> > My concern was that I already have to check for the type here in order
> to see whether to call the callback or recurse, so I thought it was cleaner
> to have two callbacks, but I don't feel very strongly about that.
> Why not always call the callback? We have a set to avoid a loop.
> Cheers, Rafael
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-commits