[PATCH] D15272: [Verifier] Verifier that a GlobalValue is only used in this Module

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 23 06:57:54 PST 2015

On 23 December 2015 at 09:51, Keno Fischer <kfischer at college.harvard.edu> wrote:
> loladiro added inline comments.
> ================
> Comment at: lib/IR/Verifier.cpp:451
> @@ -450,1 +450,3 @@
> +template <typename CB1, typename CB2>
> +static void
> ----------------
> rafael wrote:
>> Why do you need a template? Looks like the callbacks always have the name type, no?
> Is there a good way to name a C++ lambda (I know about std::function, but AFAIK that has performance implications, so I tend to avoid it)?

No, there isn't.

At a first look I didn't realize the lambdas were using local vars.

You can use a llvm::function_ref if you are worried about performance.


More information about the llvm-commits mailing list