[PATCH] D15724: AMDGPU/SI: fix scratch resource register allocation on Tonga & Iceland

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 22 13:53:48 PST 2015

arsenm added a comment.

Do you have a test that hits this?

This is also repeated for the ScratchWaveOffsetReg below, so that probably also needs this.

I don't really remember why I did it this way. At this point we should know exactly which registers vcc/flat_scr/xnack should be in

Comment at: lib/Target/AMDGPU/SIFrameLowering.cpp:124
@@ -123,2 +123,3 @@
     // this is the 2nd to last element already.
-    for (MCPhysReg Reg : getAllSGPR128().drop_back(2).slice(NumPreloaded)) {
+    unsigned Drop = 2;
This should also account for flat_scr. I'm not sure we have a way to check if flat_scr is needed yet


More information about the llvm-commits mailing list