[PATCH] D15642: [asan] Use private aliases for global variables (LLVM part).

Maxim Ostapenko via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 22 09:38:35 PST 2015

m.ostapenko added a comment.

In http://reviews.llvm.org/D15642#313943, @kcc wrote:

> The change in general makes sense, but is potentially very intrusive, and hard to test on the small set of unit tests. 
>  We'll need to test it on a larger code base. Did you test it on something large? 
>  I afraid Chromium tests are not an adequate test target for this functionality, but it would be a good start.

Yeah, you are right, the change seems to be intrusive. I ran Chromium tests with the patch and hit on -fvisibililty=hidden stuff (we should not export _asan_genXXX symbols for hidden globals), so we should be very careful here. I'm updating the diff.

As for something really big, I thought Android would be a good candidate (AFAIK, Eugeni hit on ODR fiasco there), but I'm not sure I can build and run it without help (at least I don't have a target device). It would be nice if you could help me here somehow.



More information about the llvm-commits mailing list