[PATCH] D15662: [gc.statepoint] Change gc.statepoint intrinsic's return type to token type instead of i32 type

Manuel Jacob via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 22 08:36:25 PST 2015

mjacob accepted this revision.
mjacob added a reviewer: mjacob.
mjacob added a comment.

LGTM, too. I skimmed over the tests, and they seem to be fine. I can't comment on the invoke-related changes, though.

Comment at: include/llvm/IR/Intrinsics.td:582-586
@@ -581,7 +581,7 @@
 // Deprecated: will be removed in a couple of weeks
 def int_experimental_gc_result_int : Intrinsic<[llvm_anyint_ty], [llvm_i32_ty]>;
 def int_experimental_gc_result_float : Intrinsic<[llvm_anyfloat_ty],
 def int_experimental_gc_result_ptr : Intrinsic<[llvm_anyptr_ty], [llvm_i32_ty]>;
These should either be updated or removed before committing this revision. I'd prefer the last option because these intrinsics were deprecated about 11 months ago. I'll prepare a revision for that.


More information about the llvm-commits mailing list