[PATCH] D10725: Improve testing for the C API

Chandler Carruth via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 22 00:52:33 PST 2015


chandlerc added inline comments.

================
Comment at: tools/llvm-c-test/echo.cpp:1-12
@@ +1,13 @@
+/*===-- echo.c - tool for testing libLLVM and llvm-c API ------------------===*\
+|*                                                                            *|
+|*                     The LLVM Compiler Infrastructure                       *|
+|*                                                                            *|
+|* This file is distributed under the University of Illinois Open Source      *|
+|* License. See LICENSE.TXT for details.                                      *|
+|*                                                                            *|
+|*===----------------------------------------------------------------------===*|
+|*                                                                            *|
+|* This file implements the --echo commands in llvm-c-test.                   *|
+|*                                                                            *|
+\*===----------------------------------------------------------------------===*/
+
----------------
Note that as this is now C++ code just using the C API, this header should be updated to be the normal C++ header...

================
Comment at: tools/llvm-c-test/echo.cpp:286
@@ +285,3 @@
+    clone_bb(Cur, Dst, VMap);
+    Count--;
+    Next = LLVMGetNextBasicBlock(Cur);
----------------
Perhaps more relevantly, this is C++ code now, so you don't need stdbool.h or anything ,you can use all the glorious power of C++. ;]


http://reviews.llvm.org/D10725





More information about the llvm-commits mailing list