[PATCH] D9151: Loop Versioning for LICM

[Nema, Ashutosh via llvm-commits]

Hi Tobias,

> I wonder if there is a specific reason this pass is run as in the 
> canonicalization phase as part of the inliner loop.
Not very clear, what you mean by 'inliner loop', is it inner loop ?

> Would it not make more sense to run it before the vectorizers?
If you see pass manager its scheduled prior to Vectorizer. 
As its LICM based, it’s not performing any vectorizer legality. 
It helps in cases where LICM became conservative because of 
memory aliasing uncertainty.

Thanks,
Ashutosh

-----Original Message-----
From: Tobias Grosser [mailto:tobias at grosser.es] 
Sent: Tuesday, December 22, 2015 2:48 AM
To: Nema, Ashutosh; anemet at apple.com; hfinkel at anl.gov; listmail at philipreames.com; charlie.turner at arm.com
Cc: mehdi.amini at apple.com; sanjoy at playingwithpointers.com; javed.absar at arm.com; silviu.baranga at arm.com; llvm-commits at lists.llvm.org
Subject: Re: [PATCH] D9151: Loop Versioning for LICM

grosser added a subscriber: grosser.
grosser added a comment.

Dear All,

sorry for jumping in late. I wonder if there is a specific reason this pass is run as in the canonicalization phase as part of the inliner loop. Would it not make more sense to run it before the vectorizers?

Best,
Tobias


Repository:
  rL LLVM

http://reviews.llvm.org/D9151