[PATCH] D15693: [Polly] Take a PHI's incoming block as value user
Tobias Grosser via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 21 17:27:24 PST 2015
grosser added a comment.
I just went again over the patch and debugged a simple example. I have the feeling this patch is in fact not the right approach. Assume there is a PHI node in an exit block of the scop, which uses values that are defined inside the scop and for which the incoming block of the PHI node is also part of the scop. In this case, I would still expect the values used by this PHI node to be marked as escaping. With your patch this would generally not be the case (and just happens to still be the case because we first run executeScopConditionally and only then generate the list escaping values). I also do not see how handleOutsideUsers could ever have caused a bug in its current shape.
Assuming I did not misunderstand something and assuming that getUseBlock is useful in the context of another patch, we should probably leave handleOutsideUsers as it is and introduce getUseBlock with the code that actually needs it.
More information about the llvm-commits