[PATCH] D15698: TTI: Report 0 cost for free addrspacecasts

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 21 11:21:09 PST 2015


arsenm created this revision.
arsenm added a subscriber: llvm-commits.
Herald added a reviewer: tstellarAMD.

http://reviews.llvm.org/D15698

Files:
  include/llvm/CodeGen/BasicTTIImpl.h
  test/Analysis/CostModel/AMDGPU/addrspacecast.ll

Index: test/Analysis/CostModel/AMDGPU/addrspacecast.ll
===================================================================
--- /dev/null
+++ test/Analysis/CostModel/AMDGPU/addrspacecast.ll
@@ -0,0 +1,45 @@
+; RUN: opt -cost-model -analyze -mtriple=amdgcn-unknown-amdhsa -mcpu=kaveri < %s | FileCheck %s
+
+; CHECK: 'addrspacecast_global_to_flat'
+; CHECK: estimated cost of 0 for {{.*}} addrspacecast i8 addrspace(1)* %ptr to i8 addrspace(4)*
+define i8 addrspace(4)* @addrspacecast_global_to_flat(i8 addrspace(1)* %ptr) #0 {
+  %cast = addrspacecast i8 addrspace(1)* %ptr to i8 addrspace(4)*
+  ret i8 addrspace(4)* %cast
+}
+
+; CHECK: 'addrspacecast_global_to_flat_v2'
+; CHECK: estimated cost of 0 for {{.*}} addrspacecast <2 x i8 addrspace(1)*> %ptr to <2 x i8 addrspace(4)*>
+define <2 x i8 addrspace(4)*> @addrspacecast_global_to_flat_v2(<2 x i8 addrspace(1)*> %ptr) #0 {
+  %cast = addrspacecast <2 x i8 addrspace(1)*> %ptr to <2 x i8 addrspace(4)*>
+  ret <2 x i8 addrspace(4)*> %cast
+}
+
+; CHECK: 'addrspacecast_global_to_flat_v32'
+; CHECK: estimated cost of 0 for {{.*}} addrspacecast <32 x i8 addrspace(1)*> %ptr to <32 x i8 addrspace(4)*>
+define <32 x i8 addrspace(4)*> @addrspacecast_global_to_flat_v32(<32 x i8 addrspace(1)*> %ptr) #0 {
+  %cast = addrspacecast <32 x i8 addrspace(1)*> %ptr to <32 x i8 addrspace(4)*>
+  ret <32 x i8 addrspace(4)*> %cast
+}
+
+; CHECK: 'addrspacecast_local_to_flat'
+; CHECK: estimated cost of 1 for {{.*}} addrspacecast i8 addrspace(3)* %ptr to i8 addrspace(4)*
+define i8 addrspace(4)* @addrspacecast_local_to_flat(i8 addrspace(3)* %ptr) #0 {
+  %cast = addrspacecast i8 addrspace(3)* %ptr to i8 addrspace(4)*
+  ret i8 addrspace(4)* %cast
+}
+
+; CHECK: 'addrspacecast_local_to_flat_v2'
+; CHECK: estimated cost of 2 for {{.*}} addrspacecast <2 x i8 addrspace(3)*> %ptr to <2 x i8 addrspace(4)*>
+define <2 x i8 addrspace(4)*> @addrspacecast_local_to_flat_v2(<2 x i8 addrspace(3)*> %ptr) #0 {
+  %cast = addrspacecast <2 x i8 addrspace(3)*> %ptr to <2 x i8 addrspace(4)*>
+  ret <2 x i8 addrspace(4)*> %cast
+}
+
+; CHECK: 'addrspacecast_local_to_flat_v32'
+; CHECK: estimated cost of 32 for {{.*}} addrspacecast <32 x i8 addrspace(3)*> %ptr to <32 x i8 addrspace(4)*>
+define <32 x i8 addrspace(4)*> @addrspacecast_local_to_flat_v32(<32 x i8 addrspace(3)*> %ptr) #0 {
+  %cast = addrspacecast <32 x i8 addrspace(3)*> %ptr to <32 x i8 addrspace(4)*>
+  ret <32 x i8 addrspace(4)*> %cast
+}
+
+attributes #0 = { nounwind readnone }
Index: include/llvm/CodeGen/BasicTTIImpl.h
===================================================================
--- include/llvm/CodeGen/BasicTTIImpl.h
+++ include/llvm/CodeGen/BasicTTIImpl.h
@@ -343,6 +343,11 @@
         TLI->isZExtFree(SrcLT.second, DstLT.second))
       return 0;
 
+    if (Opcode == Instruction::AddrSpaceCast &&
+        TLI->isNoopAddrSpaceCast(Src->getPointerAddressSpace(),
+                                 Dst->getPointerAddressSpace()))
+      return 0;
+
     // If the cast is marked as legal (or promote) then assume low cost.
     if (SrcLT.first == DstLT.first &&
         TLI->isOperationLegalOrPromote(ISD, DstLT.second))


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D15698.43388.patch
Type: text/x-patch
Size: 3144 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151221/4c068f83/attachment.bin>


More information about the llvm-commits mailing list