[PATCH] D15334: PC-relative support for EmitValue

Tim Northover via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 21 10:36:51 PST 2015

t.p.northover added a subscriber: t.p.northover.
t.p.northover added a comment.

This looks like it's unused by the in-tree targets. What other object formats do you know of that would benefit from this? Because if it's just CoreRT then it seems like it would make more sense to keep it there, where it can be tested properly.

Comment at: include/llvm/MC/MCStreamer.h:524
@@ -523,2 +523,3 @@
   /// \param Loc - The location of the expression for error reporting.
+  /// \param IsPCRelative - It tells whether the value is PC relative or not.
   virtual void EmitValueImpl(const MCExpr *Value, unsigned Size,
I'd suggest: 

   /// \param IsPCRelative - Whether the value is PC relative or not.


More information about the llvm-commits mailing list