[PATCH] D15661: AMDGPU/SI: Fix encoding for FLAT_SCRATCH registers on VI

[Tom Stellard via llvm-commits]

tstellarAMD added inline comments.

================
Comment at: lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp:125-135
@@ -119,1 +124,13 @@
 
+bool isSI(const MCSubtargetInfo &STI) {
+  return STI.getFeatureBits()[AMDGPU::FeatureSouthernIslands];
+}
+
+bool isCI(const MCSubtargetInfo &STI) {
+  return STI.getFeatureBits()[AMDGPU::FeatureSeaIslands];
+}
+
+bool isVI(const MCSubtargetInfo &STI) {
+  return STI.getFeatureBits()[AMDGPU::FeatureVolcanicIslands];
+}
+
----------------
arsenm wrote:
> Can these be defined in the header?
No, because then you need to move the TableGen generated Subtarget enums into the headers which may cause conflicts with other files that also include them.


http://reviews.llvm.org/D15661