[PATCH] D15663: [AArch64]: Add support for Exynos-M1

Christof Douma via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 21 04:00:02 PST 2015


christof added inline comments.

================
Comment at: lib/Target/ARM/ARM.td:255
@@ -254,1 +254,3 @@
 
+def ProcM1      : SubtargetFeature<"m1", "ARMProcFamily", "ExynosM1",
+                                   "Samsung Exynos-M1 processors", []>;
----------------
> ProcM1

I think that might confuse people thinking it is a ARMv8-M core rather than an ARMv8-A. Might be better to change it to ProcExynosM1 or something similar.


http://reviews.llvm.org/D15663





More information about the llvm-commits mailing list