[polly] r256139 - ScopInfo: Return in case we found an invalid array size

Tobias Grosser via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 21 01:09:40 PST 2015


Author: grosser
Date: Mon Dec 21 03:09:39 2015
New Revision: 256139

URL: http://llvm.org/viewvc/llvm-project?rev=256139&view=rev
Log:
ScopInfo: Return in case we found an invalid array size

Without this return we still log the incorrect array size (and do not detect
this scop), but we would unnecessarily continue to verify that access functions
are affine. As we do not need to do this, we can return right ahead and
consequently safe compile time.

This issue was found by inspection.

Modified:
    polly/trunk/lib/Analysis/ScopDetection.cpp

Modified: polly/trunk/lib/Analysis/ScopDetection.cpp
URL: http://llvm.org/viewvc/llvm-project/polly/trunk/lib/Analysis/ScopDetection.cpp?rev=256139&r1=256138&r2=256139&view=diff
==============================================================================
--- polly/trunk/lib/Analysis/ScopDetection.cpp (original)
+++ polly/trunk/lib/Analysis/ScopDetection.cpp Mon Dec 21 03:09:39 2015
@@ -643,7 +643,7 @@ bool ScopDetection::hasValidArraySizes(D
       }
     }
     if (hasScalarDepsInsideRegion(DelinearizedSize, &CurRegion))
-      invalid<ReportNonAffineAccess>(
+      return invalid<ReportNonAffineAccess>(
           Context, /*Assert=*/true, DelinearizedSize,
           Context.Accesses[BasePointer].front().first, BaseValue);
   }




More information about the llvm-commits mailing list