[PATCH] D15668: [attrs] Split off the forced attributes utility into its own pass that can be potentially run much earlier than FuncitonAttrs proper.

[Sanjoy Das via llvm-commits]

sanjoy added inline comments.

================
Comment at: lib/Transforms/IPO/ForceFunctionAttrs.cpp:81
@@ +80,3 @@
+    }
+    if (F.hasFnAttribute(Kind))
+      continue;
----------------
chandlerc wrote:
> sanjoy wrote:
> > Minor, but might be clearer as
> > 
> > ```
> > if (!F.hasFnAttribute(Kind))
> >   F.addFnAttr(Kind);
> > ```
> > 
> > (unless you plan to add more things to the non `continue;` branch later)
> Just moving code around here. I can clean it up in a follow-up patch?
sgtm.


http://reviews.llvm.org/D15668