[PATCH] D15235: [ELF] - Implemented R_*_IRELATIVE relocations for x86, x64 targets.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Sat Dec 19 00:10:53 PST 2015


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: ELF/Target.cpp:369-372
@@ -356,4 +368,6 @@
 bool X86TargetInfo::relocNeedsPlt(uint32_t Type, const SymbolBody &S) const {
+  if (isGnuIFunc<ELF32LE>(S))
+    return true;
   return (Type == R_386_PLT32 && canBePreempted(&S, true)) ||
          (Type == R_386_PC32 && S.isShared());
 }
----------------
This can be

  return isGnuIFunc<ELF32LE>(S) ||
         (Type == R_386_PLT32 && ...


http://reviews.llvm.org/D15235





More information about the llvm-commits mailing list