[PATCH] D15661: AMDGPU/SI: Fix encoding for FLAT_SCRATCH registers on VI

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 18 18:58:26 PST 2015


arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp:125-135
@@ -119,1 +124,13 @@
 
+bool isSI(const MCSubtargetInfo &STI) {
+  return STI.getFeatureBits()[AMDGPU::FeatureSouthernIslands];
+}
+
+bool isCI(const MCSubtargetInfo &STI) {
+  return STI.getFeatureBits()[AMDGPU::FeatureSeaIslands];
+}
+
+bool isVI(const MCSubtargetInfo &STI) {
+  return STI.getFeatureBits()[AMDGPU::FeatureVolcanicIslands];
+}
+
----------------
Can these be defined in the header?


http://reviews.llvm.org/D15661





More information about the llvm-commits mailing list