[PATCH] D15638: [symbolizer] Fix a dangling pointer in LLVMSymbolizer::getOrCreateObjects

Alexey Samsonov via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 18 12:23:29 PST 2015


samsonov added a comment.

This is wrong for several reasons: first of all, there are many calls to getObjectFileFromBinary, and you likely need to do smth. similar for all of them. But then it somewhat defeats the purpose of caching: we essentially keep object files in memory even if they don't have object file for appropriate architecture. Looks like this code needs to be reworked, and at the very least `ObjectFileForArch` should not have raw pointers as keys. I'll look into that.


http://reviews.llvm.org/D15638





More information about the llvm-commits mailing list