[PATCH] D15417: [mips][microMIPS] Implement BEQZC and BNEZC instructions

Zoran Jovanovic via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 18 02:00:37 PST 2015


zoran.jovanovic added inline comments.

================
Comment at: lib/Target/Mips/MCTargetDesc/MipsMCCodeEmitter.cpp:346
@@ +345,3 @@
+
+  // TODO: Push fixup.
+  return 0;
----------------
dsanders wrote:
> Shouldn't this be filled in? The previous patch (D15526) added the necessary fixup.
> 
> Could you also add a test case covering this path?
This patch is first patch and patch D15526 depends on this one.
D15526 adds necessary fixup and contains corresponding test cases.


http://reviews.llvm.org/D15417





More information about the llvm-commits mailing list