[PATCH] D15633: Clarify that the bypassSlowDivision optimization operates on a single BB [v2]

Justin Lebar via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 17 17:32:20 PST 2015


jlebar created this revision.
jlebar added reviewers: tyler.nowicki, hfinkel.
jlebar added a subscriber: llvm-commits.

Update some comments to be more explicit.

Change bypassSlowDivision and the functions it calls so that they take
BasicBlock*s and Instruction*s, rather than Function::iterator&s and
BasicBlock::iterator&s.

Change the APIs so that the caller is responsible for updating the
iterator, rather than the callee.  This makes control flow much easier
to follow.

http://reviews.llvm.org/D15633

Files:
  include/llvm/Transforms/Utils/BypassSlowDivision.h
  lib/CodeGen/CodeGenPrepare.cpp
  lib/Transforms/Utils/BypassSlowDivision.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D15633.43201.patch
Type: text/x-patch
Size: 10419 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151218/5e81760d/attachment.bin>


More information about the llvm-commits mailing list