[PATCH] D15541: [PGO] generate different version for FE instrumentation and IR level instrumentation profiles

Rong Xu via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 17 14:03:47 PST 2015


xur added inline comments.

================
Comment at: lib/profile/InstrProfiling.c:22
@@ +21,3 @@
+/* IR level instrumentation declares a strong symbol and sets the value to 1. */
+__attribute__((weak)) int __llvm_profile_ir_level = 0;
+
----------------
davidxl wrote:
> use macro LLVM_ATTRIBUTE_WEAK
Macro LLVM_ATTRIBUTE_WEAK is defined in llvm/Support/Compiler.h. It seems to me we should include that header here (also that is  a c++ header).
There are also other direct uses of __attribute__((weak)) in InstrProfilingFile.c.


http://reviews.llvm.org/D15541





More information about the llvm-commits mailing list