[PATCH] D15390: [ThinLTO] Launch importing backends in parallel threads from gold plugin

Rafael Ávila de Espíndola via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 17 13:35:20 PST 2015


rafael added inline comments.

================
Comment at: tools/gold/gold-plugin.cpp:83
@@ -80,1 +82,3 @@
+  std::unique_ptr<ld_plugin_input_file> File;
+  bool Valid;
 
----------------
OK. If we have a std::unique_ptr, we can use it instead of the Valid field, no? Valid is false iff File is null.


http://reviews.llvm.org/D15390





More information about the llvm-commits mailing list