[PATCH] D15390: [ThinLTO] Launch importing backends in parallel threads from gold plugin

Rafael Ávila de Espíndola via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 17 09:07:20 PST 2015


rafael added inline comments.

================
Comment at: tools/gold/gold-plugin.cpp:81
@@ -77,3 +80,3 @@
 struct PluginInputFile {
-  void *handle;
-  ld_plugin_input_file File;
+  void *Handle;
+  std::unique_ptr<ld_plugin_input_file> File;
----------------
Please rebase the patch.

================
Comment at: tools/gold/gold-plugin.cpp:82
@@ +81,3 @@
+  void *Handle;
+  std::unique_ptr<ld_plugin_input_file> File;
+  bool Valid;
----------------
You can just memcpy the ld_plugin_input_file, no ?


http://reviews.llvm.org/D15390





More information about the llvm-commits mailing list