[PATCH] D13426: Move types in the LLVM C API from Core to Support

[Eric Christopher via llvm-commits]

echristo added a comment.

Few more inline comments.

Thanks!

-eric


================
Comment at: docs/ReleaseNotes.rst:45
@@ +44,3 @@
+* With this release, the C API headers have been reorganized to improve build
+  time. Various typedef moved to Type.h so most of the LLVM codebase can depend
+  on it rather than the whole C API. Nothing should change for projects
----------------
"Type specific defines moved to..."

Also you added an ErrorHandling file and there's no text for it.

================
Comment at: include/llvm-c/ErrorHandling.h:1-10
@@ +1,11 @@
+/*===-- llvm-c/Support.h - Support C Interface --------------------*- C -*-===*\
+|*                                                                            *|
+|*                     The LLVM Compiler Infrastructure                       *|
+|*                                                                            *|
+|* This file is distributed under the University of Illinois Open Source      *|
+|* License. See LICENSE.TXT for details.                                      *|
+|*                                                                            *|
+|*===----------------------------------------------------------------------===*|
+|*                                                                            *|
+|* This file defines the C interface to the LLVM support library.             *|
+|*                                                                            *|
----------------
Copy and paste problem.

================
Comment at: include/llvm-c/Types.h:1-10
@@ +1,11 @@
+/*===-- llvm-c/Support.h - Support C Interface --------------------*- C -*-===*\
+|*                                                                            *|
+|*                     The LLVM Compiler Infrastructure                       *|
+|*                                                                            *|
+|* This file is distributed under the University of Illinois Open Source      *|
+|* License. See LICENSE.TXT for details.                                      *|
+|*                                                                            *|
+|*===----------------------------------------------------------------------===*|
+|*                                                                            *|
+|* This file defines the C interface to the LLVM support library.             *|
+|*                                                                            *|
----------------
Cut and paste problem.


http://reviews.llvm.org/D13426