[PATCH] D15531: Change linkInModule to take a std::unique_ptr

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 16 14:44:37 PST 2015

echristo added a comment.

Couple more inline comments, but the C API stuff as far as policy is ok now.



Comment at: include/llvm-c/Linker.h:44
@@ -40,1 +43,3 @@
+/* Unlike LLVMLinkerMode this function:
+   * Doesn't take an unused parameter.

Best to just describe the function completely with a note of what it also doesn't do so that the end of deprecation removal is easier for LLVMLinkModules?

Comment at: include/llvm/Linker/Linker.h:51
@@ -50,3 +50,3 @@
-  static bool linkModules(Module &Dest, Module &Src,
-                          unsigned Flags = Flags::None);
+  /// This exists to implement a deprecate C api. Don't use for anything else.
+  bool linkInModuleForCAPI(Module &Src);
"deprecated" and go ahead and specify which one so that a grep will find this.


More information about the llvm-commits mailing list