[PATCH] D13676: [Polly] Do not store scalar accesses in InstructionToAccess

[Tobias Grosser via llvm-commits]

grosser added a comment.

Thank you Michael for this rebase. This new change is now clearly minimal such that we can now focus on the semantic change.

There are good points for this patch:

We currently do not use the InstructionToArray mapping for scalars, it was originally not introduced with scalars in mind and - in fact - us adding scalars to this mapping introduced bugs at various places (which I just fixed).

As your patch also allows us to avoid the construction of redundant scalar memory accesses in a ScopStmt, I am clearly in favor of adding it.

I understand that in certain situations we might want to know if an instruction caused scalar memory accesses, but I think such information should probably be maintained separately. Adding functionality seems to be rather simple (and orthogonal). Hence, we can do it when the need arises.

>From my point this patch is ready to commit, but let's see if people at the phone call tonight have any further thoughts.


http://reviews.llvm.org/D13676