[PATCH] D15547: [PGO] Handle and report overflow during profile merge for all types of data

[Diego Novillo via llvm-commits]

On Tue, Dec 15, 2015 at 7:35 PM, David Li <davidxl at google.com> wrote:

> davidxl added inline comments.
>
> ================
> Comment at: include/llvm/ProfileData/SampleProf.h:299
> @@ +298,3 @@
> +        addTotalSamples(Other.getTotalSamples(), Weight);
> +    if (AddTotalSamplesResult != sampleprof_error::success)
> +      Result = AddTotalSamplesResult;
> ----------------
> May be introducing a macro for the repeated patterns:
>
> #define SET_RESULT(R, FinalR) \
>   if (R != ....) \
>      FinalR = R;
>
>
No, please.  Not a macro.  An inline function.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151216/115262c5/attachment.html>