[PATCH] D14596: [SROA] Choose more profitable type in findCommonType

Chandler Carruth via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 15 19:10:23 PST 2015


chandlerc added a comment.

In http://reviews.llvm.org/D14596#311601, @Carrot wrote:

> In this function there is no explicit floating point operation, all of them are wrapped by function call. So combine pass actually works as intended. The memcpy is lowered to integer ld/st. But later in inlining pass all the complex number function calls are inlined, so in SROA pass it can see both integer ld/st and fp operations.


Yea, as David was somewhat saying, I think the interesting test case is the one after inlining where there are both integer and FP operations.


http://reviews.llvm.org/D14596





More information about the llvm-commits mailing list