[PATCH] D15390: [ThinLTO] Launch importing backends in parallel threads from gold plugin

[Teresa Johnson via llvm-commits]

tejohnson added inline comments.

================
Comment at: test/tools/gold/X86/thinlto.ll:12
@@ -8,1 +11,3 @@
+; RUN:    --plugin-opt=thinlto \
+; RUN:    -shared %t.o %t2.o -o %t4
 
----------------
rafael wrote:
> This gold invocation is not being tested.
Right, it was just checking to ensure that it succeeded without an error.

================
Comment at: test/tools/gold/X86/thinlto.ll:32
@@ +31,3 @@
+; RUN:    -shared %t.o %t2.o -o %t4
+; RUN: llvm-bcanalyzer -dump %t4.thinlto.bc | FileCheck %s --check-prefix=COMBINED
+
----------------
rafael wrote:
> These two only check the t4.thinlto.bc. Don't you want to, for example, run llvm-nm on t4?
Same as above, it was just checking for the invocation succeeding without an error. I could run llvm-nm on the output file and check for "T f", just to make sure it is there and not ill-formed. Is that what you had in mind?

================
Comment at: tools/gold/gold-plugin.cpp:33
@@ -32,2 +32,3 @@
 #include "llvm/Linker/IRMover.h"
+#include "llvm/Linker/Linker.h"
 #include "llvm/MC/SubtargetFeature.h"
----------------
rafael wrote:
> Why do you need Linker.h?
renameModuleForThinLTO


http://reviews.llvm.org/D15390