[PATCH] D15264: Fix bitcast to gep constant folding transform.

[David Majnemer via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL255536: [ConstantFold] Fix bitcast to gep constant folding transform. (authored by majnemer).

Changed prior to commit:
  http://reviews.llvm.org/D15264?vs=42387&id=42744#toc

Repository:
  rL LLVM

http://reviews.llvm.org/D15264

Files:
  llvm/trunk/lib/IR/ConstantFold.cpp
  llvm/trunk/test/Assembler/ConstantExprFoldCast.ll
  llvm/trunk/unittests/IR/ConstantsTest.cpp

Index: llvm/trunk/test/Assembler/ConstantExprFoldCast.ll
===================================================================
--- llvm/trunk/test/Assembler/ConstantExprFoldCast.ll
+++ llvm/trunk/test/Assembler/ConstantExprFoldCast.ll
@@ -15,3 +15,7 @@
 
 ; Address space cast AS0 null-> AS1 null
 @H = global i32 addrspace(1)* addrspacecast(i32* null to i32 addrspace(1)*)
+
+; Bitcast -> GEP
+ at I = external global { i32 }
+ at J = global i32* bitcast ({ i32 }* @I to i32*)
Index: llvm/trunk/lib/IR/ConstantFold.cpp
===================================================================
--- llvm/trunk/lib/IR/ConstantFold.cpp
+++ llvm/trunk/lib/IR/ConstantFold.cpp
@@ -109,7 +109,7 @@
   if (PointerType *PTy = dyn_cast<PointerType>(V->getType()))
     if (PointerType *DPTy = dyn_cast<PointerType>(DestTy))
       if (PTy->getAddressSpace() == DPTy->getAddressSpace()
-          && DPTy->getElementType()->isSized()) {
+          && PTy->getElementType()->isSized()) {
         SmallVector<Value*, 8> IdxList;
         Value *Zero =
           Constant::getNullValue(Type::getInt32Ty(DPTy->getContext()));
Index: llvm/trunk/unittests/IR/ConstantsTest.cpp
===================================================================
--- llvm/trunk/unittests/IR/ConstantsTest.cpp
+++ llvm/trunk/unittests/IR/ConstantsTest.cpp
@@ -433,5 +433,22 @@
   }
 }
 
+TEST(ConstantsTest, BitcastToGEP) {
+  LLVMContext Context;
+  std::unique_ptr<Module> M(new Module("MyModule", Context));
+
+  auto *i32 = Type::getInt32Ty(Context);
+  auto *U = StructType::create(Context, "Unsized");
+  Type *EltTys[] = {i32, U};
+  auto *S = StructType::create(EltTys);
+
+  auto *G = new GlobalVariable(*M, S, false,
+                               GlobalValue::ExternalLinkage, nullptr);
+  auto *PtrTy = PointerType::get(i32, 0);
+  auto *C = ConstantExpr::getBitCast(G, PtrTy);
+  ASSERT_EQ(dyn_cast<ConstantExpr>(C)->getOpcode(),
+            Instruction::BitCast);
+}
+
 }  // end anonymous namespace
 }  // end namespace llvm


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D15264.42744.patch
Type: text/x-patch
Size: 1995 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151214/903e9632/attachment.bin>