[PATCH] D15499: Add AlmostReadNone and AlmostArgMemOnly attributes and set it for a few libc functions. Enhance GlobalsAA

[Mehdi AMINI via llvm-commits]

joker.eph added a subscriber: joker.eph.
joker.eph added a comment.

I don't see changes to the LangRef?


================
Comment at: include/llvm/IR/Attributes.td:23
@@ +22,3 @@
+/// that is accessible from the IR.
+def AlmostReadNone : EnumAttr<"almostreadnone">;
+
----------------
Can you clarify in the description that ReadNone is stricter that AlmostReadNone (i.e. one contains the other)? (if I understood correctly)

================
Comment at: include/llvm/IR/Attributes.td:29
@@ +28,3 @@
+/// its arguments.
+def AlmostArgMemOnly : EnumAttr<"almostargmemonly">;
+
----------------
Again if we could make very clear and explicit the relationship between AlmostArgMemOnly and ArgMemOnly in the description.

================
Comment at: include/llvm/IR/Function.h:296
@@ -295,1 +295,3 @@
 
+  /// @brief Determine if the function may read only non IR visible globals, 
+  /// and does not access any IR visible globals.
----------------
`@brief` unneeded here.


Repository:
  rL LLVM

http://reviews.llvm.org/D15499