[PATCH] D15146: [InstCombine] Look through PHIs, GEPs, IntToPtrs and PtrToInts to expose more constants when comparing GEPs

James Molloy via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 14 03:19:10 PST 2015


jmolloy added inline comments.

================
Comment at: lib/Transforms/InstCombine/InstCombineCompares.cpp:679
@@ +678,3 @@
+  for (Value *Val : Explored) {
+    for (auto Use = Val->use_begin(); Use != Val->use_end(); ++Use) {
+
----------------
It does! :)

================
Comment at: lib/Transforms/InstCombine/InstCombineCompares.cpp:805
@@ +804,3 @@
+
+  // If required, create a inttoptr instruction.
+  Value *NewBase = Base;
----------------
Ah OK, My bad misreading this.


http://reviews.llvm.org/D15146





More information about the llvm-commits mailing list