[PATCH] D15401: Refactor threshold computation for inline cost analysis

David Li via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 11 22:41:54 PST 2015


davidxl added inline comments.

================
Comment at: lib/Analysis/InlineCost.cpp:1414
@@ +1413,3 @@
+}
+
+// Returns the inline threshold for a given callsite whose callee is explicitly
----------------
sounds reasonable.

================
Comment at: lib/Analysis/InlineCost.cpp:1414
@@ +1413,3 @@
+}
+
+// Returns the inline threshold for a given callsite whose callee is explicitly
----------------
davidxl wrote:
> sounds reasonable.
I thought the threshold was the opt level independent one -- but looks like not. See my previous comments -- we should need to pass any threshold.


Repository:
  rL LLVM

http://reviews.llvm.org/D15401





More information about the llvm-commits mailing list