[PATCH] D15344: [WebAssembly] Implement prolog/epilog insertion and FrameIndex elimination

[Dan Gohman via llvm-commits]

sunfish added a comment.

lgtm (with the new changes).


================
Comment at: lib/Target/WebAssembly/WebAssembly.h:42
@@ -41,1 +41,3 @@
 
+FunctionPass *createWebAssemblyPEI();
+
----------------
It isn't stated so, but the passes above are ordered in the order that they run (except for Relooper, which is not currently run). Would you mind moving the PEI pass up just below RegColoring?

================
Comment at: lib/Target/WebAssembly/WebAssemblyFrameLowering.cpp:154
@@ -74,1 +153,3 @@
+      .addMemOperand(MMO);
+
 }
----------------
Nit: unnecessary blank line here.

================
Comment at: lib/Target/WebAssembly/WebAssemblyPEI.cpp:185
@@ +184,3 @@
+
+  //assert(!Fn.getRegInfo().getNumVirtRegs() && "Regalloc must assign all vregs");
+
----------------
This is one of the changes to the generic PEI, right? Could you add a comment?


http://reviews.llvm.org/D15344