[PATCH] D15139: [IR] Reformulate LLVM's EH funclet IR

[Joseph Tremoulet via llvm-commits]

JosephTremoulet added inline comments.

================
Comment at: include/llvm/IR/InstrTypes.h:1122
@@ +1121,3 @@
+
+  explicit FuncletPadInst(Instruction::FuncletPadOps Op, Value *OuterScope,
+                          ArrayRef<Value *> Args, unsigned Values,
----------------
(here and other constructors and `Create` methods) parameter should probably be renamed `ParentPad` as well.

================
Comment at: lib/CodeGen/WinEHPrepare.cpp:207
@@ -243,1 +206,3 @@
+static const BasicBlock *getEHPadFromPredecessor(const BasicBlock *BB,
+                                                 Value *OuterScope) {
   const TerminatorInst *TI = BB->getTerminator();
----------------
This parameter name too

================
Comment at: lib/IR/Verifier.cpp:2994
@@ -3032,1 +2993,3 @@
 
+  auto *OuterScope = CPI.getParentPad();
+  Assert(isa<CatchSwitchInst>(OuterScope) ||
----------------
nit: Also these locals (this, visitCatchSwitchInst, and visitTerminatePadInst)


http://reviews.llvm.org/D15139