[PATCH] D13151: Expand loop reroll to handle loop with multiple induction variables and negative increment -part 2/3

[hfinkel@anl.gov via llvm-commits]

hfinkel accepted this revision.
hfinkel added a comment.

LGTM.

We should really get this enabled by default for functions when optimizing for size. Care to take a stab at that?


================
Comment at: lib/Transforms/Scalar/LoopRerollPass.cpp:1370
@@ +1369,3 @@
+        if (Inst->getType()->isPointerTy()) {
+          assert(SizeOfExpr && " SizeOfExpr is not initialized");
+          MinusPlus1SCEV = SE->getMulExpr(MinusPlus1SCEV, SizeOfExpr);
----------------
No space after first "


Repository:
  rL LLVM

http://reviews.llvm.org/D13151