[PATCH] D15306: [llvm-profdata] Add support for weighted merge of profile data (2nd try)

[Xinliang David Li via llvm-commits]

When a file is specified via --weighted-file, does it need to be
specified again later in the command line or it is optional?

David

On Thu, Dec 10, 2015 at 3:35 PM, Sean Silva <chisophugis at gmail.com> wrote:
> silvas added a comment.
>
> In http://reviews.llvm.org/D15306#307692, @davidxl wrote:
>
>> I misunderstood your proposal. Your proposal is a modified version of
>>  the originally proposed option that requires weight to be specified
>>  for every file (and with implicit ordering assumption).  To specify
>>  more than one file with weight, does user have to use multiple
>>  --weight-file option?
>
>
> Yes. What I'm suggesting is precisely like the current patch, except that `--weighted-file=<weight>,<filename>` is used instead of `<filename>:<weight>`. (I do not care about `--weighted-file` syntax per se; it could be `-weighted-file`, `-file-with-weight`, etc. whatever is most convenient to implement. The fundamental thing is to reuse the user intuition about passing options in order to avoid exposing users to another special case (argument syntax is already a special case, but one that users are aware of).
>
>
> http://reviews.llvm.org/D15306
>
>
>