[Patch] Change linkInModule to take a std::unique_ptr

[Teresa Johnson via llvm-commits]

LGTM. Thanks,
Teresa

On Thu, Dec 10, 2015 at 2:07 PM, Rafael Espíndola
<rafael.espindola at gmail.com> wrote:
> On 10 December 2015 at 10:22, Teresa Johnson <tejohnson at google.com> wrote:
>> Thanks! A few comments/suggestions below.
>> Teresa
>>
>>> +* The C API function LLVMLinkModules is deprecated. It will be removed in the
>>> +  3.9 release. Please migrate to LLVMLinkModules2.
>>
>> Do we need a similar migration strategy for
>> linker_ocaml.c:llvm_link_modules? I.e. create a new llvm_link_modules2
>> and indicate the former is deprecated? Otherwise, users may be
>> blissfully unaware that the implementation of that interface will
>> change.
>
> My understanding is that the only thing we offer API stability for is
> the C api, so the go and ocaml bindings can just be changed like the
> C++ API itself.
>
> An updated patch with your suggestions is attached.
>
> Cheers,
> Rafael



-- 
Teresa Johnson | Software Engineer | tejohnson at google.com | 408-460-2413