[PATCH] D15328: [x86][avx512] more changes in intrinsics to be align with gcc format

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 10 13:42:35 PST 2015


Seems reasonable to me. It just seemed odd that we were changing. Header
compatibility isn't necessarily a good reason, but being able to keep
source compatibility if possible is nice.

Thanks!


On Thu, Dec 10, 2015 at 1:41 PM Craig Topper via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> The stance I had always taken was that if clang and gcc both have a
> builtin for something we match them. If clang doesn't need a builtin and
> gcc does then we just don't match.
>
> On Thursday, December 10, 2015, Elena Demikhovsky via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
>
>> delena added a subscriber: delena.
>> delena added a comment.
>>
>> Hi Eric,
>>
>> We did not complete the SKX intrinsics yet. We are adding them to the
>> backend and to the clang. And we still have a lot of work to do.
>> The names and parameters should be the same in GCC and in Clang headers.
>> The current patch is just a minor fix.
>> Could you, please, explain your point?
>>
>> - Elena
>>
>> From: Eric Christopher [mailto:echristo at gmail.com]
>> Sent: Thursday, December 10, 2015 20:23
>> To: reviews+
>> http://reviews.llvm.org/D15328+public+c78cb0b2afbde1c2@reviews.llvm.org;
>> Demikhovsky, Elena <elena.demikhovsky at intel.com>
>> Subject: Re: [PATCH] http://reviews.llvm.org/D15328: [x86][avx512] more
>> changes in intrinsics to be align with gcc format
>>
>> Why again? We're already not compatible because we don't handle, nor do
>> we want to, other builtins.
>>
>> -eric
>>
>>
>> Repository:
>>   rL LLVM
>>
>> http://reviews.llvm.org/D15328
>>
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>
>
>
> --
> ~Craig
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151210/3234b00f/attachment.html>


More information about the llvm-commits mailing list