[PATCH] D15139: [IR] Reformulate LLVM's EH funclet IR

Joseph Tremoulet via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 10 12:21:21 PST 2015


JosephTremoulet added inline comments.

================
Comment at: lib/Transforms/Utils/InlineFunction.cpp:1099
@@ +1098,3 @@
+  Instruction *CallSiteEHPad = nullptr;
+  if (CalledPersonality && CallerPersonality) {
+    EHPersonality Personality = classifyEHPersonality(CalledPersonality);
----------------
JosephTremoulet wrote:
> This could be
> 
>   if (CallerPersonality) {
>     assert(CalledPersonality);
> 
> since the code just above sets CalledPersonality if it is null but CallerPersonality is not.
...no, I just totally misread that.  Sorry for the noise.


http://reviews.llvm.org/D15139





More information about the llvm-commits mailing list