[PATCH] D15425: AMDGPU/SI: Select constant loads with non-uniform addresses to MUBUF instructions

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 10 11:31:02 PST 2015


arsenm added inline comments.

================
Comment at: lib/Target/AMDGPU/SIISelLowering.cpp:514
@@ +513,3 @@
+	// UndefValue means this is a load of a kernel input.  These are uniform.
+	if (isa<UndefValue>(Ptr) || isa<Argument>(Ptr))
+		return true;
----------------
arsenm wrote:
> This maybe should check constant isa<Constant> which happens occasionally for LDS
Probably also the various kinds of symbols


http://reviews.llvm.org/D15425





More information about the llvm-commits mailing list